👍 Remove args from error messages of call/batch
#376
Conversation
`args` may contains some sensitive information or massive data.
WalkthroughThe changes primarily involve the removal of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
denops/@denops-private/host/vim.ts (1)
Line range hint
110-116: Refactor suggestion: Remove redundant else clause.The else clause is unnecessary and can be omitted to simplify the code structure.
- else if (isInvokeMessage(expr)) { + if (isInvokeMessage(expr)) {
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- denops/@denops-private/host.ts (1 hunks)
- denops/@denops-private/host/nvim.ts (3 hunks)
- denops/@denops-private/host/nvim_test.ts (2 hunks)
- denops/@denops-private/host/vim.ts (3 hunks)
- denops/@denops-private/host/vim_test.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- denops/@denops-private/host.ts
- denops/@denops-private/host/nvim_test.ts
Additional context used
Learnings (1)
denops/@denops-private/host/vim.ts (1)
User: Milly PR: vim-denops/denops.vim#352 File: denops/@denops-private/testutil/host.ts:3-4 Timestamp: 2024-05-25T06:35:34.785Z Learning: `Neovim` and `Vim` from `../host/nvim.ts` and `../host/vim.ts` are classes and should be imported normally if they are instantiated in the code.
Biome
denops/@denops-private/host/vim.ts
[error] 110-116: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
Additional comments not posted (6)
denops/@denops-private/host/vim.ts (2)
56-56: Approved: Updated error message format incallmethod.The error message now correctly formats the function name within single quotes, enhancing readability and security by not exposing arguments.
75-78: Approved: Updated error message format inbatchmethod.The error message now includes the function name in a clear format, aligning with the updated error handling strategy.
denops/@denops-private/host/nvim.ts (2)
66-66: Approved: Updated error message format incallmethod.The error message now correctly formats the function name within single quotes, enhancing readability and security by not exposing arguments.
83-86: Approved: Updated error message format inbatchmethod.The error message now includes the function name in a clear format, aligning with the updated error handling strategy.
denops/@denops-private/host/vim_test.ts (2)
73-73: Approved: Updated error message format in test forcallmethod.The test now correctly checks for the updated error message format, ensuring consistency with the main codebase.
99-99: Approved: Updated error message format in test forbatchmethod.The test now correctly checks for the updated error message format, ensuring consistency with the main codebase.
argsmay contains some sensitive information or massive data.It follows the decision in #374
Summary by CodeRabbit
Refactor
Tests